Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replication) fix replication hang seems when enable internal tls #11641

Closed
wants to merge 1 commit into from
Closed

fix(replication) fix replication hang seems when enable internal tls #11641

wants to merge 1 commit into from

Conversation

bitsf
Copy link
Contributor

@bitsf bitsf commented Apr 16, 2020 •
edited
Loading

Try fix issue #11642
It seems when enable internal tls, transfer some bigger blob, it will hang at
https://github.com/goharbor/harbor/blob/master/src/pkg/registry/client.go#L390

the root reason is not clear now, it seems set req.ContentLength = -1 can workaround.

@bitsf
fix(replication) fix replication hang seems when enable internal tls
212d214 
Signed-off-by: Ziming Zhang <zziming@vmware.com>
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #11641 into master will decrease coverage by 4.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11641      +/-   ##
==========================================
- Coverage   55.54%   51.31%   -4.24%     
==========================================
  Files         910      267     -643     
  Lines       52686    12324   -40362     
  Branches     1788     1788              
==========================================
- Hits        29265     6324   -22941     
+ Misses      20155     5416   -14739     
+ Partials     3266      584    -2682
Flag Coverage Δ
#unittests 51.31% <ø> (-4.24%) ⬇️
Impacted Files Coverage Δ
...ig/vulnerability/vulnerability-config.component.ts 47.77% <0.00%> (-4.46%) ⬇️
...or/harbor/src/replication/adapter/gitlab/client.go
...thub.com/goharbor/harbor/src/core/api/usergroup.go
.../v2.0/restapi/operations/artifact/copy_artifact.go
...rc/pkg/permission/evaluator/rbac/casbin_adapter.go
...oharbor/harbor/src/replication/dao/schedule_job.go
...ub.com/goharbor/harbor/src/common/dao/testutils.go
...b.com/goharbor/harbor/src/jobservice/job/op_cmd.go
...harbor/harbor/src/server/middleware/v2auth/auth.go
...b.com/goharbor/harbor/src/jobservice/job/models.go
... and 634 more

@bitsf
Copy link
Contributor Author

bitsf commented Apr 16, 2020

This fix will break Quota function that depend on content length

@bitsf bitsf closed this Apr 16, 2020
@bitsf bitsf deleted the fix_replication_hang branch June 18, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reasonerjt reasonerjt reasonerjt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitsf @reasonerjt